Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update from gitlab web hook #32

Open
jxn opened this issue Apr 24, 2018 · 3 comments
Open

Allow update from gitlab web hook #32

jxn opened this issue Apr 24, 2018 · 3 comments

Comments

@jxn
Copy link

jxn commented Apr 24, 2018

It'd be really nice to allow requests coming from gitlab webhooks update projects, or better yet just that one project associated with the webhook, so we don't have to wait for cron.

It looks very easy to trigger update from webhook, but given the architecture, it looks a bit challenging to only update a given repository without checking all others. Any interest in this? It'd require a pretty decent refactor.

@lemoinem
Copy link
Contributor

lemoinem commented Apr 25, 2018

That's a great idea!

I, unfortunately, don't have the time to work on it. However, I would be more than open to review and discuss any PR you could submit.

I think updating the packages piece-wise might be easier than you think (in particular, have a look at $load_data and $fetch_ref. However, the main part of packages.php would need to be refactored so to accomodate this, indeed.

If I may, I think it would be best to have the option (but not be forced to) rely on the webhooks. For example via a configuration or something.

@keywan-ghadami-oxid
Copy link

@jxn I am working on webhook implementation any help or feed back is welcome keywan-ghadami-oxid#2

@keywan-ghadami-oxid
Copy link

Here we go #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants