Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

[demo] feet removal not working when contrast < 0.87 #7

Open
roytam1 opened this issue Apr 1, 2020 · 7 comments
Open

[demo] feet removal not working when contrast < 0.87 #7

roytam1 opened this issue Apr 1, 2020 · 7 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@roytam1
Copy link

roytam1 commented Apr 1, 2020

it seems to be base font weight dependent. in ExtLight weight, it happens when contrast < 0.77

@roytam1 roytam1 changed the title [demo] feet removal not working when contrast is 0.75 [demo] feet removal not working when contrast < 0.87 Apr 1, 2020
@celestialphineas
Copy link
Member

This is a known issue, probably a problem with stroke width estimation. The feet removal algorithm fails when meeting extreme parameters. Perhaps this will not be fixed, since the extreme cases usually look bad. But the feet removal method will be improved in the next version anyway.

@celestialphineas celestialphineas added the bug Something isn't working label Apr 1, 2020
@celestialphineas celestialphineas self-assigned this Apr 1, 2020
@celestialphineas celestialphineas added the wontfix This will not be worked on label Apr 1, 2020
@celestialphineas
Copy link
Member

celestialphineas commented Apr 1, 2020

At least feet removal works well for Glow Sans Thin Compressed (180):

You may check out if your contrast setting is too high or low.

@MY1L
Copy link

MY1L commented Apr 21, 2020

Demo Link

也是去脚问题:
目前中国这样口居中的字去脚效果可以,左右结构里口偏上的明湖看起来也可以,但遇到口垫底的字排版起来效果就……显得相对同一行的其它字飘起来了。这一类字Demo里没有希望添加:名容兽音(整体飘起)飴(右边飞升)我暂时只测试出这几字,怀疑是普遍现象。

可以用“包括作者姓名与内容特征”这句测试,可以发现“名容”浮起一点。

@celestialphineas
Copy link
Member

Demo Link

也是去脚问题:
目前中国这样口居中的字去脚效果可以,左右结构里口偏上的明湖看起来也可以,但遇到口垫底的字排版起来效果就……显得相对同一行的其它字飘起来了。这一类字Demo里没有希望添加:名容兽音(整体飘起)飴(右边飞升)我暂时只测试出这几字,怀疑是普遍现象。

可以用“包括作者姓名与内容特征”这句测试,可以发现“名容”浮起一点。

目前已经下降1/4脚高作为补偿了,做到完美是很难的。

@MY1L
Copy link

MY1L commented Apr 21, 2020

目前已经下降1/4脚高作为补偿了,做到完美是很难的。

我模拟效果,可能凡是原位于最底的口,底横直接顶到与原脚底平齐似乎可以?如果Demo能提供脚高变量,我可以测试出相对较好的参数。

@roytam1
Copy link
Author

roytam1 commented Oct 1, 2020

in 0.91, 嘒 and 嘔 are still have feet in main components, feet in radicals are removed though. (noticed in GlowSansJ-Normal-Regular.otf)

@celestialphineas
Copy link
Member

Feet removal is hard to make perfect. At present time, 匚 & 匸 in TC/J do not feature the feet removal, since the removal may also affect 非 components. I will look into this later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants