Skip to content
This repository has been archived by the owner on Aug 27, 2023. It is now read-only.

I think you need to change the glyphs some more... #23

Open
Marcus98T opened this issue Oct 2, 2020 · 5 comments
Open

I think you need to change the glyphs some more... #23

Marcus98T opened this issue Oct 2, 2020 · 5 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Marcus98T
Copy link

Marcus98T commented Oct 2, 2020

I know you started with Genne Gothic as a base, but unfortunately I do not believe that the font has the full Kangxi glyphs. I also want to upstream some changes from SHS v2.001. Even though it is for 源樣黑體, the table also have Source Han Sans CID.

The 牙 radical has to follow that of 源樣黑體, not the KR form. I don't have the time to find the Unicode number and CID number for Source Han Sans.
Affected characters: "牙冴訝呀邪鴉雅芽穿". You need to dig into the hidden glyphs of Source Han Sans in order to get those glyphs.
Screenshot 2020-10-02 at 14 29 20

The characters with 呈 need to be changed also. Affected characters are "呈程浧珵桯鋥聖檉".
Use the TW form: "呈程聖"
Use the JP form: "浧珵桯鋥檉"
Screenshot 2020-10-02 at 14 35 50

Also the 青/靑, 清/淸, need to unify to the latter. Same with U+7BC0 節; need to use U+FA56 (Update: It's at SHS v2 CID: 58950) for the main codepoint. Details here: #22

More characters I want to switch here, should apply to this font also:
ButTaiwan/genyog-font#21
ButTaiwan/genyo-font#9

Add the U+32FF ㋿ SQUARE ERA NAME REIWA from Source Han Sans v2.001 as well.

@celestialphineas
Copy link
Member

Given the computational nature of Glow Sans, manual glyph fixes are not under consideration, and it is a shame that, font build for Glow Sans has ignored the original CID of Source Han Sans, which makes such problems even harder to fix, unless I have enough time on this project to rewrite the building scripts.

Adding support for other Unicode blocks is working in process. Hopefully, the Reiwa glyph (U+32FF ㋿) will be included in future versions.

@celestialphineas celestialphineas added bug Something isn't working wontfix This will not be worked on labels Oct 2, 2020
@Marcus98T
Copy link
Author

Marcus98T commented Oct 2, 2020

If so, I suppose the CID for Glow Sans (Genne Gothic) was based on Source Han Sans v1.004, and then the CID for v2.001 is all changed. This will take quite a lot of time and work to pinpoint where the glyphs exactly are. I may not have the time to pinpoint every single glyph that needs changing, but I might use the Source Han Sans v2.001 CID as a starting point, followed by the respective Unicode codepoint (or CID) of Glow Sans to change to, if that's what you want.

@celestialphineas
Copy link
Member

Full v2.001 CID correspondence for a classical orthography is certainly welcomed. I would appreciate it if someone would have such data.

@Marcus98T
Copy link
Author

Marcus98T commented Oct 3, 2020

Unfortunately as you know, v2 of SHS removes extra JP glyphs like 惦 because of the demand for HK glyphs. So I can only at most partially take from v2 for some glyph fixes, as mentioned in my top comment.

Unfortunately, I don't have so much time to do an exact list as you wish, this can take up to a month for me to furnish such a desired list, but the hint is to look within these ranges of CIDs:

  • 58855 to 58973
  • 61800 to 61853
  • 61896 to 63107 (the majority where the hidden Kangxi glyphs are and most are mapped to the KR version of SHS, but not all)

@Marcus98T
Copy link
Author

Change these glyphs to the CID of Source Han Sans v2.002:

  • 欤 to 62445
  • 婦 to 62216
  • 寧 to 62232
  • 呈 to 62157
  • 程 to 62572
  • 聖 to SHS TC form
  • 篠 to SHS JP form
  • 肏 to SHS TC form
  • 条 to 62396
  • 空 to 62578 (optional, not required)
  • 控 to 62337 (optional, not required)
  • 腔 to 62689 (optional, not required)
  • 与 to 62068
  • 主 to 62073
  • 住 to 62078
  • 拄 to SHS JP form
  • 往 to 62276
  • 注 to 62456
  • 駐 to 63041
  • 柱 to 62404
  • 註 to SHS JP form
  • 免 to 58914 (same codepoint as U+FA32)
  • 悗 to 62288
  • 晚 to 62368
  • 兔 to 61806
  • 冤 to SHS JP form
  • 起 to 62827

If I said SHS JP form, for example, which means take from version 2.002 of the Japanese version of Source Han Sans. I don't know where the CID is, but the desired form is encoded into the specific font by default.

More to come soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants