More work on pecl-memcache #76
Conversation
Zaffy
commented
Oct 8, 2020
Zaffy
commented
- added test for "Memcache session handling, zend_mm_heap corrupted" on bugs.php.net #65 and fixed the leak
- added support for reflection Add ReflectionParameter param information for functions and methods? #64
- added test for Fix crash when serialization fails #53
- fixed failing tests including session redundancy weird behaviour when reopening session during request #46 and session_start(): Failed to read session data: memcache using php7.2 #57
- fixed underlying issue in Test in Symfony's HttpFoundation failing with websupport-sk/pecl-memcache under PHP 7 #7
- fixed binary protocol support
- fixed found memory leaks
I think that these might have uninitialized bytes when a data type larger than zend_bool is used for the ini setting, if the module globals are set from malloc? (Not 100% sure if the entire structure isn't set to 0 before being used) Related to #56
Use zend_bool for ini bool settings
Conflicts: php8/memcache.c
This will allow us to have one unified branch that will compile under different versions of php.
- added / updated arginfos - fix functions returning NULL instead of advertised return type, For example, when memcached returned error on "delete", function returned null instead of false - added tests for both php8 and 7
Co-authored-by: Tyson Andre <tyson.andre@uwaterloo.ca>
|
Would be nice to have a test case covering the Trying to get this ready for PHP8: https://github.com/Automattic/wp-memcached/blob/master/object-cache.php#L327 If I can help somehow, do tell. |
|
You should be able to target both php8 and php7 with the php8 branch. |
|
Thanks @Zaffy. Tested with the php8 branch, working as expected. |
