-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCDataChannel::close() does not wait for channel to close #517
Comments
It looks like the DataChannel::close() is incorrect.
Also Stream::shutdown() calls send_reset_request only when both channels are shutdown.
If I have understood correctly, there should be a way to shutdown write side, and call send_reset_request. |
RTCDataChannel::close() calls
DataChannel::close(), which calls
Stream::shutdown() which calls
Stream::send_reset_request().
Stream::send_reset_request() does not wait for connection close.
So there is no way to wait for shutdown handshake to complete.
In my code I call RTCPeerConnection::close() after RTCDataChannel::close() and since we there is no wait for buffered messages to be sent some messages will be lost.
The text was updated successfully, but these errors were encountered: