-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger menu invisible in dark mode on mobile #33
Comments
It's not invisible in Chrome on my Android, a OnePlus 6s I think? What device do you have? Click the hamburger on the top left of the screen for it to show up. |
The hamburger is quasi-invisible in dark mode both on Chrome and Firefox. Now, I can't seem to figure out WHICH dark mode I've enabled for Chrome, let me see if I can figure it out Anyway, the GitHub hamburger is visible in dark mode in all browsers |
Hi, I'm looking into this, but I can't recereate -- how are you enabling dark mode? @mralusw |
chrome://flags/#enable-force-dark Turning this on (which is the only documented way to make webpages dark) makes the page https://webrtcforthecurious.com/, well, dark, and the hamburger invisible. |
It's not just the hamburger menus, also the translation and edit icon. It's because the SVGs in the Hugo theme are all black, so inverting them should work. Seems to be some good tips here: https://web.dev/prefers-color-scheme/#invert-vector-graphics-and-icons Alternatively, we could just make them dark grey with something like:
|
Chrome on Android here.
The sidebar is invisible, and so the book seems to consist of just the Introduction landing page.
And yes, please use pandoc to provide EPUB downloads, as mentioned in another issue.
The text was updated successfully, but these errors were encountered: