Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for map<enum_type, some_other_type> #44

Open
c2h5oh opened this issue Apr 29, 2019 · 4 comments
Open

Add support for map<enum_type, some_other_type> #44

c2h5oh opened this issue Apr 29, 2019 · 4 comments
Labels
todo items we should do
Milestone

Comments

@c2h5oh
Copy link
Contributor

c2h5oh commented Apr 29, 2019

Right now only basic types are supported

@pkieltyka
Copy link
Member

@c2h5oh perhaps the issue is using enum_type as the key. webrpc might right now require string or number as the key, but any value is supported already as you can see in https://github.com/webrpc/webrpc/blob/master/_examples/golang-basics/example.ridl#L46

for enum_type, since its number based, should be pretty easy to add support for it eventually

@c2h5oh
Copy link
Contributor Author

c2h5oh commented May 13, 2019

That's exactly what this ticket is about - being able to end up with map[enumType]valueType on go side

@pkieltyka
Copy link
Member

@xiam this would be really nice to add support for too, and should be easy to support in parser since enum's are all numbers under the hood

@pkieltyka pkieltyka added the todo items we should do label Aug 7, 2023
@pkieltyka pkieltyka modified the milestones: next, queued Feb 23, 2024
@pkieltyka
Copy link
Member

btw, im pretty sure once #55 is solved, then this ticket will be closed along with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo items we should do
Projects
None yet
Development

No branches or pull requests

3 participants