Document name
and Move Example
#54
Comments
I give the standardisation REDAME overhaul here some priority :), if someone with more experience using the plugin (@sullenor) could help to clearify the usage of |
@skipjack as far as I know the Since the example describes the two configurations (one for each language) I assume that the Check this out: webpack --config-name de
webpack --config-name en |
@sullenor thanks for that clarification, your description makes sense. Can you point me to an example or the source code where that |
@skipjack looks like it was added in webpack version 3.4.0 (just found the release note) and implemented in that commit webpack/webpack@3c77b07 The option can be used in case you have multi-compilation (your's webpack config expose an array of configurations). Using it you may choose particular configurations to run. I guess it was added to solve some performance issues :) Here is another example of usage https://github.com/webpack/webpack/tree/master/examples/multi-compiler#webpackconfigjs I'm not quite familiar with webpack-cli repo, but webpack has a cli interface build in: https://github.com/webpack/webpack/blob/master/bin/config-optimist.js |
See the comments in the originals but essentially the issue is that in the example on the main repo, there is a
name
option passed to the actual webpack config which isn't mentioned in this package's readme, the example, or in the main webpack configuration documentation:I dug through the code a bit but couldn't figure out if or how that
name
property is used. Does this plugin actually use it in some way or does it just help identify locale-specific configs while debugging?I would suggest two things (and I'd be happy to help with them):
The second is more of an overall thing... I think those examples at the main repo lead to a bit of confusion for users. Imho they should either be located in the docs repo or the repo for the package they describe. I think I or @hovissimo would be happy to help push this forward just looking for some advice/clarification.
The text was updated successfully, but these errors were encountered: