Bug: Concatenate strings in i18n #32

Rincewind3d · 2017-02-08T08:07:41Z

Hello,

this may be a basic problem/limitation from Webpack, but perhaps someone has an idea.

If i18n is called with a string concatenation Webpack throws an reference error.

let foo = 'foo';
__('bar.'+foo);

ReferenceError: __ is not defined

I checked the i18n-webpack-plugin code and figured out the the problem is this.evaluateExpression(expr.arguments[0]) which is not working if there's string concatenation. My knowledge about webpack plugins is limited, perhaps someone has an idea?

The use for this string concatenation is in combination with the html-webpack-plugin.
For each site I define a template variable with the name of the site and use it to get the translation for the header title.

<head>
  <title>${__('view.' + htmlWebpackPlugin.options.environment.viewName + '.title')}</title>
</head>

Yeah, es6 template would be better. But as in #6 described it's not working.

The text was updated successfully, but these errors were encountered:

sullenor · 2017-08-04T11:42:35Z

Hi, the current version works only with the string literals as an argument as you found earlier and skips other combinations (binary expressions and e.t.c.). Thats why the function call __() remains untouched which results in exception.

I did a small modification in #58 which provides possibility to use string concatenation (BinaryExpressions) and templated strings (TemplateLiteral) with variables also. But it requires some time for review and to land into the master.

michael-ciniawsky added the question label Apr 14, 2017

joshwiens removed the question label Apr 16, 2017

sullenor added the type: Enhancement label Aug 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: Concatenate strings in i18n #32

Bug: Concatenate strings in i18n #32

Rincewind3d commented Feb 8, 2017

sullenor commented Aug 4, 2017 •

edited

Bug: Concatenate strings in i18n #32

Bug: Concatenate strings in i18n #32

Comments

Rincewind3d commented Feb 8, 2017

sullenor commented Aug 4, 2017 • edited

sullenor commented Aug 4, 2017 •

edited