Fix static analysis in ci #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerkms
reviewed
Oct 19, 2022
| @@ -42,7 +42,7 @@ function allThrows(iterable $value, $class): iterable | |||
| * @param iterable<Closure|null> $value | |||
| * @param class-string<Throwable> $class | |||
| * | |||
| * @return iterable<Closure> | |||
| * @return iterable<Closure|null> | |||
There was a problem hiding this comment.
What does this test test after this change?
|
FYI: This does not fix #275 - the problem in my issue is, that the checks are not executed in the CI pipeline of this project and thus errors are not properly detected in builds. These changes here are only fixing issues which would be detected if static analysis would be properly added to the CI pipeline but not the problem itself, that checks are not executed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #275, the first commit upgrades pslam so that psalm can be run from a subdirectory again. And the second commit fixes all currently occurring errors.