Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all* methods are actually impure #248

Open
BackEndTea opened this issue Jun 5, 2021 · 0 comments
Open

all* methods are actually impure #248

BackEndTea opened this issue Jun 5, 2021 · 0 comments

Comments

@BackEndTea
Copy link
Collaborator

Ran into this while seeing if we could use psalm to check the code base itself.

So the question is, should we mark them as impure?

ERROR: ImpureMethodCall - src/Mixin.php:3210:9 - Cannot call a possibly-mutating Traversable::getIterator from a pure context (see https://psalm.dev/203)
        foreach ($array as $entry) {
            static::isNonEmptyMap($entry, $message);
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant