Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor worker should use streaming unzip #1066

Closed
brollb opened this issue Jul 19, 2016 · 2 comments
Closed

executor worker should use streaming unzip #1066

brollb opened this issue Jul 19, 2016 · 2 comments

Comments

@brollb
Copy link
Contributor

brollb commented Jul 19, 2016

Rather than unzipping using the system installed unzip binary, it might be more useful to use a streaming unzip such as https://github.com/EvanOxfeld/node-unzip as this would also remove the system dependency

@ksmyth
Copy link
Contributor

ksmyth commented Jul 19, 2016

Note it is impossible to properly extract a .zip in a streaming manner,
since the central directory is at the end
https://github.com/thejoshwolfe/yauzl#no-streaming-unzip-api

node-unzip has lots of github issues and seems abandoned

On Tue, Jul 19, 2016 at 3:50 PM, Brian Broll notifications@github.com
wrote:

Rather than unzipping using the system installed unzip binary, it might be
more useful to use a streaming unzip such as
https://github.com/EvanOxfeld/node-unzip as this would also remove the
system dependency


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1066, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_9BTtT48ohpkX8xc8xj782eS0NVVC3ks5qXTiJgaJpZM4JQKAL
.

@brollb
Copy link
Contributor Author

brollb commented Jul 20, 2016

my bad - I see what you mean EvanOxfeld/node-unzip#95

@brollb brollb closed this as completed Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants