Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Pugi Symbol Conflicts #55

Open
webern opened this issue Feb 18, 2020 · 0 comments
Open

Prevent Pugi Symbol Conflicts #55

webern opened this issue Feb 18, 2020 · 0 comments
Labels
bug software defect non-breaking fixes or implementation that do not require breaking changes

Comments

@webern
Copy link
Owner

webern commented Feb 18, 2020

Per @p-groarke in #53

Embedding pugixml in your repo like you did will make mx unusable to anyone who links directly with pugixml in their project (duplicate symbols). You can google "dependency hell" for more info (yes, that's the real name). To fix that, you could use something super robust like conan to install pugi when you build mx. Or you can use the less robust ExternalProject_Add as well. I would be happy to send a PR with any of those solutions.

True, embedding could be retained but this could be fixed by patching the pugi namespace to something else.

See webern/ezxml#6

@webern webern added the bug software defect label Feb 26, 2020
@webern webern added the non-breaking fixes or implementation that do not require breaking changes label Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug software defect non-breaking fixes or implementation that do not require breaking changes
Projects
None yet
Development

No branches or pull requests

1 participant