Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppearanceData TODO in LayoutFunctions.cpp #101

Open
webern opened this issue Jun 13, 2020 · 0 comments
Open

Fix AppearanceData TODO in LayoutFunctions.cpp #101

webern opened this issue Jun 13, 2020 · 0 comments
Labels
non-breaking fixes or implementation that do not require breaking changes

Comments

@webern
Copy link
Owner

webern commented Jun 13, 2020

Fix this TODO

Sourcecode/private/mx/impl/LayoutFunctions.cpp:421

            for( const auto& other : appearance.getOtherAppearanceSet() )
            {
                api::AppearanceData data{};
                data.appearanceType = api::AppearanceType::Distance;
                data.appearanceSubType = core::toString( other->getAttributes()->type );

                // TODO - fix
                data.value = 0.0;//other->getValue().getValue();
                outDefaults.appearance.emplace_back( std::move( data ) );
            }
@webern webern added breaking fixes or implementation that require breaking changes non-breaking fixes or implementation that do not require breaking changes and removed breaking fixes or implementation that require breaking changes labels Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking fixes or implementation that do not require breaking changes
Projects
None yet
Development

No branches or pull requests

1 participant