Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name field #119

Open
bennypowers opened this issue May 3, 2023 · 1 comment · May be fixed by #123
Open

Package name field #119

bennypowers opened this issue May 3, 2023 · 1 comment · May be fixed by #123

Comments

@bennypowers
Copy link
Contributor

It occurs me that the Package entity doesn't have a name field. This may present a problem if the user only has access to the custom-elements.json, but not the package.json

for example, when pre-loading manifests into a language server, a la Matsuuu/custom-elements-language-server#20

@justinfagnani
Copy link
Collaborator

I think this is a good idea, especially if we see tools that combine manifests at all.

My big comment on #123 is that we need to figure out some namespacing system, since npm isn't the only package registry. There's GitHub packages, JSR, and private registries.

As a start, should we either require an npm: prefix, or assume that plain names are npm packages?

cc @mannix-lei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment