Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the port when the WebServer is actual started #47

Open
chtheis opened this issue Nov 2, 2011 · 1 comment
Open

Allow setting the port when the WebServer is actual started #47

chtheis opened this issue Nov 2, 2011 · 1 comment
Labels

Comments

@chtheis
Copy link
Contributor

chtheis commented Nov 2, 2011

Maybe I do strange things ... :)

I use the WebServer as an embedded server. The server is setup once, i.e., all handlers added and started / stopped by the use. Before actually starting the server the user may change the port the server is listening on. Unfortunately here the port can only be set when the server instance is created, though those settings aren't used until the server is actually started.

I have a patch where the server has a default constructor (no port at all) and a start method with a port parameter. The port must be specified once (at least), either in the constructor or in the start method.

@joewalnes
Copy link
Member

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants