TODO Items for web2project v4.0-rc1, rc2, and release #346
Assignees
Milestone
Comments
This was referenced Jan 2, 2024
Closed
caseysoftware
changed the title
|
Update:
|
|
|
Exactly where in the process should the update check been handle?
ToDo
Fix the system module to get past the update check. Not sure of the cause
yet.
…On Sun, 7 Jan 2024, 07:19 Keith Casey, ***@***.***> wrote:
- Fix the system module to get past the update check. Not sure of the
cause yet.
- Within that module, fix the Syskeys which aren't being displayed or
processed correctly.
- Rename some fields to match our naming conventions & update the
corresponding modules to use them.
- Review and merge the useful bits from the w2p_3.4pre branch into
php-8-compat
- Review and merge the useful bits from the w2p_3.5_new_Features
branch into php-8-compat
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7TZ4LXW6ZRP2A4YSDM3YNI465AVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZHE3DQMZSGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Is it based on the version?
Jan
…On Sun, 7 Jan 2024, 08:09 Jan Bakke, ***@***.***> wrote:
Exactly where in the process should the update check been handle?
ToDo
Fix the system module to get past the update check. Not sure of the cause
yet.
On Sun, 7 Jan 2024, 07:19 Keith Casey, ***@***.***> wrote:
>
> - Fix the system module to get past the update check. Not sure of the
> cause yet.
> - Within that module, fix the Syskeys which aren't being displayed or
> processed correctly.
> - Rename some fields to match our naming conventions & update the
> corresponding modules to use them.
> - Review and merge the useful bits from the w2p_3.4pre branch into
> php-8-compat
> - Review and merge the useful bits from the w2p_3.5_new_Features
> branch into php-8-compat
>
> —
> Reply to this email directly, view it on GitHub
> <#346 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAVG7TZ4LXW6ZRP2A4YSDM3YNI465AVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZHE3DQMZSGE>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
The update check is in |
|
Thx Keith
I did a brand new installation, but I can't find any updates not installed?
(I haven't checked it all yet).
Even dp21rc1_to_21rc2.sql hav been updated.
Still "Fix the system module to get past the update check. Not sure of the
cause yet." is not crossed off (it did previously).
Jan
…On Mon, Jan 8, 2024 at 4:35 AM Keith Casey ***@***.***> wrote:
The update check is in modules/system/index.php and compares the latest
database schema in the database (w2p_versions table) against the
available sql files in install/sql/
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7TYRKXN3GXIUPT5FZ6LYNNSQZAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGM2DCNJYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
You need to get the |
|
...and 059_pre_v4.0_fixes.sql
…On Mon, Jan 8, 2024 at 6:10 AM Jan Bakke ***@***.***> wrote:
Thx Keith
I did a brand new installation, but I can't find any updates not
installed? (I haven't checked it all yet).
Even dp21rc1_to_21rc2.sql hav been updated.
Still "Fix the system module to get past the update check. Not sure of the
cause yet." is not crossed off (it did previously).
Jan
On Mon, Jan 8, 2024 at 4:35 AM Keith Casey ***@***.***>
wrote:
> The update check is in modules/system/index.php and compares the latest
> database schema in the database (w2p_versions table) against the
> available sql files in install/sql/
>
> —
> Reply to this email directly, view it on GitHub
> <#346 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAVG7TYRKXN3GXIUPT5FZ6LYNNSQZAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGM2DCNJYGQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
" You need to get the php-8-compat branch specifically." I have.
What exactly "wasn't actually solved"?
Jan
…On Mon, Jan 8, 2024 at 6:18 AM Keith Casey ***@***.***> wrote:
You need to get the php-8-compat branch specifically.
And yes, I un-crossed it off as I hit the issue again so it wasn't
actually solved.
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7TY6PPVQH5PENCAP7WLYNN6RPAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGM4TQMJQGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
The In the meantime, I just pushed a bunch of commits cherry picked from |
|
More importantly, once I debug the |
|
I noticed when i run 059_pre_v4.0_fixes.sql an error when I manually run it;
Unknown column 'file_date' in 'files'
Jan
…On Mon, Jan 8, 2024 at 6:44 AM Keith Casey ***@***.***> wrote:
The system module issue. Because that's not fixed, you may have to
manually run install\sql\059_pre_v4.0_fixes.sql and
install\sql\060_pre_v4.0_standardizing.sql manually.
In the meantime, I just pushed a bunch of commits cherry picked from
w2p_3.5_new_Features. It's not all of them but the bulk (21 of 37 iirc).
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7T5SG3FGSIHX7OFPKODYNOBVHAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGQYTKNJWHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
In 001_base_install.sql
CREATE TABLE `files` (
...
`file_date` datetime default NULL,
but in the table the field is named ' *file_datetime'*
Jan
…On Mon, Jan 8, 2024 at 7:17 AM Jan Bakke ***@***.***> wrote:
I noticed when i run 059_pre_v4.0_fixes.sql an error when I manually run
it;
Unknown column 'file_date' in 'files'
Jan
On Mon, Jan 8, 2024 at 6:44 AM Keith Casey ***@***.***>
wrote:
> The system module issue. Because that's not fixed, you may have to
> manually run install\sql\059_pre_v4.0_fixes.sql and
> install\sql\060_pre_v4.0_standardizing.sql manually.
>
> In the meantime, I just pushed a bunch of commits cherry picked from
> w2p_3.5_new_Features. It's not all of them but the bulk (21 of 37 iirc).
>
> —
> Reply to this email directly, view it on GitHub
> <#346 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAVG7T5SG3FGSIHX7OFPKODYNOBVHAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGQYTKNJWHE>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
Strange, because the line in 059_pre_v4.0_fixes.sql actually renames the
fileld.
ALTER TABLE `files` CHANGE `file_date` `file_datetime` DATETIME NULL
DEFAULT NULL;
…On Mon, Jan 8, 2024 at 8:05 AM Jan Bakke ***@***.***> wrote:
In 001_base_install.sql
CREATE TABLE `files` (
...
`file_date` datetime default NULL,
but in the table the field is named ' *file_datetime'*
Jan
On Mon, Jan 8, 2024 at 7:17 AM Jan Bakke ***@***.***>
wrote:
> I noticed when i run 059_pre_v4.0_fixes.sql an error when I manually run
> it;
> Unknown column 'file_date' in 'files'
>
> Jan
>
> On Mon, Jan 8, 2024 at 6:44 AM Keith Casey ***@***.***>
> wrote:
>
>> The system module issue. Because that's not fixed, you may have to
>> manually run install\sql\059_pre_v4.0_fixes.sql and
>> install\sql\060_pre_v4.0_standardizing.sql manually.
>>
>> In the meantime, I just pushed a bunch of commits cherry picked from
>> w2p_3.5_new_Features. It's not all of them but the bulk (21 of 37 iirc).
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#346 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAVG7T5SG3FGSIHX7OFPKODYNOBVHAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGQYTKNJWHE>
>> .
>> You are receiving this because you commented.Message ID:
>> ***@***.***>
>>
>
|
|
Probably my fault regarding file_datetime, re-instaled and now it uned
fine:
BUT
it's a couple of missing semicolons in 060_pre_v4.0_standardizing.sql
UPDATE `module_config` SET `module_config_value` = 'event_start_datetime'
WHERE `module_config_value` = 'event_start_date'
UPDATE `module_config` SET `module_config_value` = 'event_end_datetime'
WHERE `module_config_value` = 'event_end_date'
…On Mon, Jan 8, 2024 at 8:16 AM Jan Bakke ***@***.***> wrote:
Strange, because the line in 059_pre_v4.0_fixes.sql actually renames the
fileld.
ALTER TABLE `files` CHANGE `file_date` `file_datetime` DATETIME NULL
DEFAULT NULL;
On Mon, Jan 8, 2024 at 8:05 AM Jan Bakke ***@***.***>
wrote:
> In 001_base_install.sql
> CREATE TABLE `files` (
> ...
> `file_date` datetime default NULL,
> but in the table the field is named ' *file_datetime'*
>
> Jan
>
> On Mon, Jan 8, 2024 at 7:17 AM Jan Bakke ***@***.***>
> wrote:
>
>> I noticed when i run 059_pre_v4.0_fixes.sql an error when I manually run
>> it;
>> Unknown column 'file_date' in 'files'
>>
>> Jan
>>
>> On Mon, Jan 8, 2024 at 6:44 AM Keith Casey ***@***.***>
>> wrote:
>>
>>> The system module issue. Because that's not fixed, you may have to
>>> manually run install\sql\059_pre_v4.0_fixes.sql and
>>> install\sql\060_pre_v4.0_standardizing.sql manually.
>>>
>>> In the meantime, I just pushed a bunch of commits cherry picked from
>>> w2p_3.5_new_Features. It's not all of them but the bulk (21 of 37
>>> iirc).
>>>
>>> —
>>> Reply to this email directly, view it on GitHub
>>> <#346 (comment)>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/AAVG7T5SG3FGSIHX7OFPKODYNOBVHAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGQYTKNJWHE>
>>> .
>>> You are receiving this because you commented.Message ID:
>>> ***@***.***>
>>>
>>
|
|
Thanks and fixed! |
|
Hi from Greece,
A few years back, I have developed a customized version of Web2project for a customer and added specific functionality:
* Add repeated task, taking into account the “not working” dates
* See an overview of tasks for previous week, this week and next week.
Would you like me to send you the customized version, to be included in the current version (no strings attached)?
Regards,
Manolis Papadopoulos
|
|
I'd love to check it out but I'm trying to get 4.0 wrapped up first. Is it on Github? If so, please share. If not, please post it and share it there. Either way, I can look at it post-4.0 |
|
Hi Keith
When i immediately finished installing refreshing the page
(/web2project/install/index.php)
Then "*Welcome to the web2Project Update Manager*!" is fired, hope this
helps.
Jan
…On Tue, Jan 9, 2024 at 4:04 PM Keith Casey ***@***.***> wrote:
I'd love to check it out but I'm trying to get 4.0 wrapped up first.
Is it on Github? If so, please share. If not, please post it and share it
there. Either way, I can look at it post-4.0
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7T5PZED6ZDRMI4Y2BDLYNVL7VAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGIYTQOBRGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Looks like $dPconfig in UpgradeManager.class.php line 30 isn't defined.
Jan
On Wed, Jan 10, 2024 at 4:39 AM Jan Bakke ***@***.***>
wrote:
… Hi Keith
When i immediately finished installing refreshing the page
(/web2project/install/index.php)
Then "*Welcome to the web2Project Update Manager*!" is fired, hope this
helps.
Jan
On Tue, Jan 9, 2024 at 4:04 PM Keith Casey ***@***.***>
wrote:
> I'd love to check it out but I'm trying to get 4.0 wrapped up first.
>
> Is it on Github? If so, please share. If not, please post it and share it
> there. Either way, I can look at it post-4.0
>
> —
> Reply to this email directly, view it on GitHub
> <#346 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAVG7T5PZED6ZDRMI4Y2BDLYNVL7VAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGIYTQOBRGU>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
...or never pass if (isset($dPconfig)) under the installation process
(still line 30)
Jan
On Wed, Jan 10, 2024 at 4:56 AM Jan Bakke ***@***.***>
wrote:
… Looks like $dPconfig in UpgradeManager.class.php line 30 isn't defined.
Jan
On Wed, Jan 10, 2024 at 4:39 AM Jan Bakke ***@***.***>
wrote:
> Hi Keith
> When i immediately finished installing refreshing the page
> (/web2project/install/index.php)
> Then "*Welcome to the web2Project Update Manager*!" is fired, hope this
> helps.
>
> Jan
>
> On Tue, Jan 9, 2024 at 4:04 PM Keith Casey ***@***.***>
> wrote:
>
>> I'd love to check it out but I'm trying to get 4.0 wrapped up first.
>>
>> Is it on Github? If so, please share. If not, please post it and share
>> it there. Either way, I can look at it post-4.0
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#346 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AAVG7T5PZED6ZDRMI4Y2BDLYNVL7VAVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGIYTQOBRGU>
>> .
>> You are receiving this because you commented.Message ID:
>> ***@***.***>
>>
>
|
|
Updates:
Open items to get v4.0-rc1 completed:
|
|
Did you see my email regarding upgrade manager?
Jan
…On Sun, 14 Jan 2024, 07:59 Keith Casey, ***@***.***> wrote:
Updates:
- Figured out and debugged what was happening with the system module
- Merged a bunch of things from w2p_3.5_new_Features branch into
php-8-compat
Open items to get v4.0-rc1 completed:
- Pull request and merge php8-compat into master
- Update the build process to package it up properly
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7T5MEYIUNITDRZHW56LYON633AVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQHA3DMMZSHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
No, please create a new thread to track details. |
|
Ok, will do.
It's further up in this thread
Jan
…On Sun, 14 Jan 2024, 09:17 Keith Casey, ***@***.***> wrote:
No, please create a new thread to track details.
—
Reply to this email directly, view it on GitHub
<#346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVG7TZHZASD6LPFFFTXMADYOOIB5AVCNFSM6AAAAABBJVNZESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQHA4DAOJQGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is my todo list for a web2project 4.0 Release Candidate 1:
systemmodule to get past the update check. Not sure of the cause yet.w2p_3.4prebranch intophp-8-compatw2p_3.5_new_Featuresbranch intophp-8-compatIf all goes well with that, I'll start working on Release Candidate 2:
build.xml) with the latest instructionsAnd if everything goes well there, I'll put together the actual web2project 4.0 release:
php-8-compatintomasterThe text was updated successfully, but these errors were encountered: