fix: [BREAKING] remove legacy subscription; change subscription interface #394
+187
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry I plan to review this this weekend, thanks! |
Minishlink
reviewed
Feb 28, 2024
| $associativeArray['publicKey'] ?? null, | ||
| $associativeArray['authToken'] ?? null, | ||
| $associativeArray['contentEncoding'] ?? "aesgcm" | ||
| $associativeArray['endpoint'] ?? "", |
There was a problem hiding this comment.
endpoint shouldn't be empty, it should throw before, shouldn't it?
| $associativeArray['authToken'] ?? null, | ||
| $associativeArray['contentEncoding'] ?? "aesgcm" | ||
| $associativeArray['endpoint'] ?? "", | ||
| $associativeArray['keys']['p256dh'] ?? "", |
There was a problem hiding this comment.
I'm not sure this is an improvement, having an empty string instead of null ?
| * @author Sergii Bondarenko <sb@firstvector.org> | ||
| */ | ||
| interface SubscriptionInterface | ||
| { | ||
| public function getEndpoint(): string; | ||
|
|
||
| public function getPublicKey(): ?string; | ||
| public function getPublicKey(): string; |
There was a problem hiding this comment.
A subscription can have no public key, auth token or content encoding (sent without any payload)
Remove legacy GCM Remove old Chrome subscription support
[BREAKING] change default encoding to aes128gcm
Rotzbua
force-pushed
the
feat_type_contentencoding
branch
from
e632f72
to
59f2e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Breaking:
Feature:
Reference
fixes #381
fixes #345
reference #388