You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the document (https://web-platform-tests.org/writing-tests/file-names.html) it says:
[1] (for test type)These flags must be the last element in the filename before the extension e.g. foo-manual.html will indicate a manual test, but foo-manual-other.html will not.
[2] (for test feature) These flags are preceded by a . in the filename, and must themselves precede any test type flag, but are otherwise unordered.
So according to this, for a manual tentative test, we should write ".tentative-manual.html", but we have plenty of tests named in the reverse order, e.g. "permissions-policy/experimental-features/vertical-scroll-main-frame-manual.tentative.html", "payment-method-basic-card/empty-data-manual.https.html".
In the code [3], it basically only fetch the type flag from the first component after "-".
Despite what the document says, looks like the common pattern ppl are using is "-(.)*.html", maybe because it will be more eye pleasing to put "-" always before ".", e.g. "vertical-scroll-main-frame-manual.tentative.html" is better than "vertical-scroll-main-frame.tentative-manual.html".
Should we update the document to accept this common practice?
In the document (https://web-platform-tests.org/writing-tests/file-names.html) it says:
[1] (for test type)These flags must be the last element in the filename before the extension e.g. foo-manual.html will indicate a manual test, but foo-manual-other.html will not.
[2] (for test feature) These flags are preceded by a . in the filename, and must themselves precede any test type flag, but are otherwise unordered.
So according to this, for a manual tentative test, we should write ".tentative-manual.html", but we have plenty of tests named in the reverse order, e.g. "permissions-policy/experimental-features/vertical-scroll-main-frame-manual.tentative.html", "payment-method-basic-card/empty-data-manual.https.html".
In the code [3], it basically only fetch the type flag from the first component after "-".
wpt/tools/manifest/sourcefile.py
Lines 207 to 208 in 8814952
The text was updated successfully, but these errors were encountered: