Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[offscreen-canvas] Remove remaining 2d.path.stroke.prune.* tests for open paths from interop-2023 #454

Closed
yiyix opened this issue Sep 20, 2023 · 3 comments · May be fixed by web-platform-tests/wpt-metadata#4775
Closed

[offscreen-canvas] Remove remaining 2d.path.stroke.prune.* tests for open paths from interop-2023 #454

yiyix opened this issue Sep 20, 2023 · 3 comments · May be fixed by web-platform-tests/wpt-metadata#4775
Labels
focus area: Offscreen Canvas test-change-proposal Proposal to add or remove tests for an interop area

Comments

@yiyix
Copy link

yiyix commented Sep 20, 2023

Test List

2d.path.stroke.prune.closed.html
2d.path.stroke.prune.closed.worker.html
2d.path.stroke.prune.rect.html
2d.path.stroke.prune.rect.worker.html

Rationale

The behavior of 0-length subpaths with line-caps is subject to a longstanding whatwg/html#1079 that has never been resolved. Due to that discussion, #392 removed 0-length open subpath with linecaps.

Since the existing spec text is confusing/ambiguous and discussion finally agreed to a spec change and the new spec is not available. I think we should remove all impacted tests from the interop-2023 set until the new spec is written.
@yiyix yiyix added the test-change-proposal Proposal to add or remove tests for an interop area label Sep 20, 2023
@nt1m nt1m mentioned this issue Sep 21, 2023
Open
@foolip
Copy link
Member

foolip commented Sep 28, 2023

@nt1m can you review this for WebKit?

@jgraham can you review for Gecko?

@nt1m
Copy link
Member

nt1m commented Oct 12, 2023

@jfkthame had some feedback about this on: #392 (comment)

@nairnandu nairnandu mentioned this issue Nov 2, 2023
Closed
@nt1m
Copy link
Member

nt1m commented Nov 2, 2023

@yiyix Since all 3 browsers are now passing this. Can we close this proposal?

@nt1m nt1m closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus area: Offscreen Canvas test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove remaining 2d.path.stroke.prune.* from interop-2023 yiyix/wpt-metadata
4 participants
@zcorpan @foolip @nt1m @yiyix