Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behaviour of the 'cordon' button #3862

Open
bboreham opened this issue May 22, 2021 · 0 comments
Open

Improve behaviour of the 'cordon' button #3862

bboreham opened this issue May 22, 2021 · 0 comments

Comments

@bboreham
Copy link
Collaborator

After #3822 the merging of active controls is still a bit off - when you press 'cordon' it doesn't update for a few seconds, then you get both cordon and uncordon buttons, then a bit later the cordon button goes away.

I believe the slow reaction is because the display is updated on a 5-second timer; we could perhaps use a 'shortcut report' to speed it up.

Displaying both sides of the toggle button happens because the app merges reports from ~15 seconds of history, during which time both buttons appear in reports from the probe. Given we have special merging code for this field, maybe we can have it recognize the toggle nature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant