Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurrogateGossiper can accumulate infinite amounts of data #68

Open
bboreham opened this issue Feb 8, 2017 · 0 comments
Open

SurrogateGossiper can accumulate infinite amounts of data #68

bboreham opened this issue Feb 8, 2017 · 0 comments
Labels

Comments

@bboreham
Copy link
Contributor

bboreham commented Feb 8, 2017

Original message from weaveworks/weave#1763:

"SurrogateGossiper does not (and cannot) know how to merge GossipData, so instead it just stashes it in a queue. That is potentially unbounded since downstream connections in gossip propagation may not be able to accept data at the same rate it is received."

Note that #66 ameliorated this, in the case that some messages are exact duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant