Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP sends block forever #125

Open
bboreham opened this issue Jan 28, 2020 · 0 comments
Open

TCP sends block forever #125

bboreham opened this issue Jan 28, 2020 · 0 comments
Labels

Comments

@bboreham
Copy link
Contributor

We set a deadline on reads but not on writes. This means if something is blocking the other end of the connection we will wait forever.

Since we expect connected peers to be fairly live, a deadline around the length of a heartbeat should allow us to error on stalled peers while not affecting normal operation.
Worst case, a connection would be torn down then re-established.

Seen at weaveworks/weave#3762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant