Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimise routes calculation and topology updates for fully connected mesh of node #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

optimise routes calculation and topology updates for fully connected mesh of node #103

wants to merge 2 commits into from

Conversation

murali-reddy
Copy link
Contributor

@murali-reddy murali-reddy commented Feb 4, 2019 •
edited

Fixes #102, #104

@bboreham
Copy link
Contributor

bboreham commented Feb 4, 2019

I kind-of get what you are aiming at here, but I have a concern about the way it's done.
This PR adds an extra check into the most complicated part of the code.
I suspect much of that loop can go now - we don't need to sort lists that we know are of length 1, etc.
So, although it will lead to more lines of code, I think it will be more understandable to have a whole separate routing algorithm for the 1-hop case.

Maybe I'm wrong. We can discuss.

@murali-reddy murali-reddy changed the title optimise routes calculation for fully connected mesh of node [WIP] optimise routes calculation and topology updates for fully connected mesh of node Mar 5, 2019
@murali-reddy
Copy link
Contributor Author

Updated the PR to handle optimizations w.r.t both topology updates and routes calculations in case of fully connected mesh nodes topology.

Also as per the review comment, introducing separate routing algorithm for fully connected topology.

@murali-reddy murali-reddy changed the title [WIP] optimise routes calculation and topology updates for fully connected mesh of node optimise routes calculation and topology updates for fully connected mesh of node May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimise Peer.Routes() for fully connected mesh of node topology
2 participants
@murali-reddy @bboreham