Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great renaming #541

Open
4 of 5 tasks
tmke8 opened this issue Mar 17, 2022 · 4 comments
Open
4 of 5 tasks

The great renaming #541

tmke8 opened this issue Mar 17, 2022 · 4 comments
Labels
breaking This would be a breaking change code-change An actual code change.
Milestone

Comments

@tmke8
Copy link
Member

tmke8 commented Mar 17, 2022

Remove the lowercase aliases for the dataset classes

  • adult() -> deleted
  • compas() -> deleted

Algorithm renames

Metrics renames

@tmke8 tmke8 added the breaking This would be a breaking change label Mar 17, 2022
@tmke8 tmke8 added this to the EthicML 1.0 milestone Mar 17, 2022
@tmke8 tmke8 changed the title Rename function to better reflect their effect Rename functions to better reflect their effect Mar 17, 2022
@olliethomas
Copy link
Member

Can we consider renaming some methods as well? E.g. Kamiran -> Reweighting

@tmke8
Copy link
Member Author

tmke8 commented Mar 18, 2022 via email

@tmke8 tmke8 changed the title Rename functions to better reflect their effect The great renaming Mar 18, 2022
@olliethomas
Copy link
Member

async -> parallel

evaluate_models_async() -> evaluate_models_parallel()
run_async() -> run_parallel()

I think we should go one step further and make the async/parallel version the standard. We've spoken about this for evaluate_models, but we could do it with run too

@tmke8
Copy link
Member Author

tmke8 commented Apr 20, 2022

Yes, that sounds good.

@tmke8 tmke8 added the code-change An actual code change. label May 30, 2022
@tmke8 tmke8 modified the milestones: EthicML 1.0, EthicML 2.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This would be a breaking change code-change An actual code change.
Projects
None yet
Development

No branches or pull requests

2 participants