Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose callback for completed transitions #253

Closed
cmathew opened this issue Jul 21, 2022 · 1 comment
Closed

Expose callback for completed transitions #253

cmathew opened this issue Jul 21, 2022 · 1 comment

Comments

@cmathew
Copy link
Contributor

cmathew commented Jul 21, 2022

we have navigationPropagator.afterNavigation but it fires as the (animated) transition is beginning. Currently the only way to await the end of a transition is transitionFinished at the individual Navigable level

this new callback probably belongs at the navigator level. But something global would be useful too, for elements that don't have access to each navigator (e.g. we want to change Toolbar UI whenever a navigation finishes "somewhere")

@cmathew cmathew changed the title Expose callbacks for completed transitions Expose callback for completed transitions Jul 21, 2022
@cmathew
Copy link
Contributor Author

cmathew commented Aug 1, 2022

two options to achieve this. 1.) use a static, global event system similar to how currentScreen works today or 2.) look into scoping it per-navigator i.e. described in: #254 for currentNavigable

@cmathew cmathew closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant