Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change introduced in version 1.9.0 for Node 4.X #177

Open
robocel opened this issue May 18, 2017 · 0 comments
Open

Breaking change introduced in version 1.9.0 for Node 4.X #177

robocel opened this issue May 18, 2017 · 0 comments

Comments

@robocel
Copy link

robocel commented May 18, 2017

The change made to the file typescript.js in version 1.9.0 contains an ES6 feature that is not supported on older version of Node (such as Node 4.X):
e5659e0#diff-edcbe97b3f08275a033ef78d5ebb1911R51

If this package is intending to use semantic versioning (of course it's any library maintainers right to do any versioning scheme they'd like), then any reliance on ES6 to the exclusion of systems not yet ready to use those features would constitute a breaking change and should have resulted in version 2.0.0 of the library instead of going to 1.9.0.

In this case, I don't think the ES6 feature is vital, so I'm proposing that the feature in question be replaced with an equivalent ES5 version and released as version 1.9.1. If the decision is made to support ES6 syntax going forward, I would propose then re-releasing the original code as version 2.0.0. I'm happy to submit a PR to this effect, if you agree that this proposal is valid.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant