Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C to M] Part 1 - Update_Model #338

Merged
merged 7 commits into from
May 9, 2024
Merged

[C to M] Part 1 - Update_Model #338

merged 7 commits into from
May 9, 2024

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented May 5, 2024

This is part 1 of a big movement of functions from the controllers to models.

@HB9HIL HB9HIL added the major impact Has a major impact on the code base label May 5, 2024
@HB9HIL HB9HIL marked this pull request as ready for review May 5, 2024 07:52
@HB9HIL HB9HIL self-assigned this May 5, 2024
@HB9HIL HB9HIL requested a review from int2001 May 5, 2024 07:52
@HB9HIL
Copy link
Contributor Author

HB9HIL commented May 5, 2024

Missing:

update_dxcc because it's bit more complex because of the dynamic html in the web UI

@HB9HIL HB9HIL linked an issue May 5, 2024 that may be closed by this pull request
67 tasks
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my production. Works

Untested (but i think it'll work, since it is "only shifting" of functions): Call from cron.

Will bring more clean code in future.

@HB9HIL HB9HIL merged commit 439031b into wavelog:dev May 9, 2024
@HB9HIL HB9HIL deleted the update_model branch May 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major impact Has a major impact on the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C -> M] Code Cleanup (Progress Tracker)
2 participants