Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSL message is not added when importing adif file #323

Open
gotoradio opened this issue Apr 30, 2024 · 5 comments
Open

QSL message is not added when importing adif file #323

gotoradio opened this issue Apr 30, 2024 · 5 comments
Labels
discussion This needs a discussion what to do

Comments

@gotoradio
Copy link

When importing an adif file, the default QSL Message is not added.
It is not shown in the advanced tab and neither in the exported adif.

Wavelog version 1.5.1
Browser: iPadOS, Safari

@phl0
Copy link
Contributor

phl0 commented Apr 30, 2024

Can you please show an example of the ADIF file you imported?

@HB9HIL
Copy link
Contributor

HB9HIL commented Apr 30, 2024

@phl0 I tested aswell.

Reproduce:

  • Set a eQSL Default Message in a Station Location
  • Import an ADIF File with QSO's
  • See in LBA that there is no eQSL Default Msg for these QSO

We have to discuss wherever the eQSL Default Msg is added to these QSO if one is defined in the station location or not. Imho it would not be wrong to add it.

Maybe we could also ask @abarrau for his opinion as he built/introduced the eQSL default msg stuff. So at the moment it's working as designed. But it would be also logical if the eQSL Default Msg is added to the imported QSO's if there is one defined in the Station Location

@phl0
Copy link
Contributor

phl0 commented Apr 30, 2024

There is more to this topic than visible at first glance. IMHO the ADIF standard does not correctly state whether the field is for incoming our outgoing eQSL message. See my post here https://groups.io/g/adifdev/topic/104884450#msg9357 which has not been fully answered till now ...

@HB9HIL HB9HIL added the discussion This needs a discussion what to do label May 1, 2024
@HB9HIL
Copy link
Contributor

HB9HIL commented May 3, 2024

Well we have an deeper issue here. In my honest opinion we should not wait with resolving this issue here just with waiting for a new ADIF spec.

One possible solution and my recommendation would be:

Let's fill the QSLMSG field in ADIF import with the eQSL DefaultMsg from the station location, if this field is empty in the ADIF. This is what I would expect as a user.

I think this is the best solution in this case because we have the fence that a user can only upload ADIFs which have a matching station callsign. So it theoretically can't be another operator with another QSLMsg. If there is already a QSLMSG in the ADIF then because the user already set it in another Log Software.

@abarrau
Copy link
Contributor

abarrau commented May 4, 2024

hello all,

(sorry for delay of answer)
yes in fact, when I implemented the eQSL DefaultMsg functionality, the objective was for the final field to be filled automatically each time a QSO is created (if the eQSL DefaultMsg is defined).
So when adif is imported, if QSLMSG is empty, eQSL DefaultMsg is used for create QSO; it was forgotten on my part.

I can watch it as soon as I have some time.

73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs a discussion what to do
Projects
None yet
Development

No branches or pull requests

4 participants