Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more supported modes to SimpelFLE #315

Closed
DC1TC opened this issue Apr 27, 2024 · 6 comments · Fixed by #322
Closed

Add more supported modes to SimpelFLE #315

DC1TC opened this issue Apr 27, 2024 · 6 comments · Fixed by #322
Assignees
@HB9HIL
Labels
enhancement New feature or request wait 4 close Issue is wating for closing by issuer

Comments

@DC1TC
Copy link

DC1TC commented Apr 27, 2024

SimpleFLE does only support a very limited set of modes. E.g. DIGITALVOICE is not supported.

https://github.com/wavelog/wavelog/blob/f3a8dd68d42e2ec02294afae6230acb73eded460/assets/js/sections/simplefle.js#L469C1-L485C2

The original FLE supports way more modes:

https://df3cb.com/fle/documentation/#modes
@HB9HIL HB9HIL self-assigned this Apr 28, 2024
@HB9HIL
Copy link
Contributor

HB9HIL commented Apr 29, 2024

I agree about this one. I'll add more modes.

@HB9HIL HB9HIL added the enhancement New feature or request label Apr 29, 2024
@HB9HIL HB9HIL mentioned this issue Apr 29, 2024
Merged
@HB9HIL
Copy link
Contributor

HB9HIL commented Apr 29, 2024

@DC1TC started working on this in the background. Stay tight. Due to personal reasons you may have to wait a few days. The idea is to not only add some more modes hardcoded in javascript, but to implement all available modes we have already in the database. So we can use this data and have all modes available at a time.

@HB9HIL
Copy link
Contributor

HB9HIL commented Apr 29, 2024

@DC1TC Okay I worked on it earlier then I thought :D You can test #322 if you want. But I want to test it a bit more.

@HB9HIL HB9HIL linked a pull request Apr 30, 2024 that will close this issue
[SFLE] Adding Support for more Frequencies and Modes #322
Merged
@HB9HIL HB9HIL added the wait 4 close Issue is wating for closing by issuer label May 3, 2024
@HB9HIL
Copy link
Contributor

HB9HIL commented May 3, 2024

PR is ready 2 merge. When it's merged this issue is solved with the next release.

@HB9HIL
Copy link
Contributor

HB9HIL commented May 23, 2024

@DC1TC We just release Version 1.6. Please test and close this issue if you are happy with it :)

@DC1TC
Copy link
Author

DC1TC commented May 27, 2024

Just tested with the DF instance on Version 1.6. Works well, thank you!

@DC1TC DC1TC closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HB9HIL HB9HIL

Labels
enhancement New feature or request wait 4 close Issue is wating for closing by issuer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SFLE] Adding Support for more Frequencies and Modes HB9HIL/wavelog
2 participants
@HB9HIL @DC1TC