Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On server error 500 internal details are also returned. #65

Open
matijaSos opened this issue Sep 30, 2020 · 0 comments · May be fixed by #894
Open

On server error 500 internal details are also returned. #65

matijaSos opened this issue Sep 30, 2020 · 0 comments · May be fixed by #894
Assignees
@shayneczyzewski
Labels
bug Something isn't working no-haskell Coding task that does not need Haskell knowledge security

Comments

@matijaSos
Copy link
Contributor

Use case: I implemented getTask(id) query and when I invoked it from client with an inexistent id (not in db), server sent 500 response along with Prisma error msg.

This should not have happened, we don't want to expose the internals. We had a generic message prepared to be used but it wasn't - we need to investigate why.
@matijaSos matijaSos added the bug Something isn't working label Sep 30, 2020
@Martinsos Martinsos added the no-haskell Coding task that does not need Haskell knowledge label Mar 11, 2021
shayneczyzewski pushed a commit that referenced this issue Dec 2, 2021
feat(auth): Added flexible validation checks for User entity email an…
b6c29ce 
…d password

Adds an additional Prisma middleware for validation checks that the user
can disable and/or extend

Closes #88 and fixes #65
shayneczyzewski pushed a commit that referenced this issue Dec 2, 2021
feat(auth): Added flexible validation checks for User entity email an…
b59b57b 
…d password

Adds an additional Prisma middleware for validation checks that the user
can disable and/or extend

Closes #88 and fixes #65
@shayneczyzewski shayneczyzewski mentioned this issue Dec 2, 2021
Merged
5 tasks
shayneczyzewski pushed a commit that referenced this issue Dec 2, 2021
feat(auth): Added flexible validation checks for User entity email an…
81000d5 
…d password

Adds an additional Prisma middleware for validation checks that the user
can disable and/or extend

Closes #88 and fixes #65
This was referenced Dec 20, 2022
Closed
Open
Huntemall pushed a commit to Huntemall/wasp-dev that referenced this issue Oct 5, 2023
@matijaSos
Extracted JSON manipulation into Util. (wasp-lang#65)
cf8ad33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shayneczyzewski shayneczyzewski

Labels
bug Something isn't working no-haskell Coding task that does not need Haskell knowledge security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comment explaining default Express error handling wasp-lang/wasp
3 participants
@shayneczyzewski @Martinsos @matijaSos