Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we log OAuth errors in the server console #2026

Closed
infomiho opened this issue May 9, 2024 · 1 comment · Fixed by #2038
Closed

Make sure we log OAuth errors in the server console #2026

infomiho opened this issue May 9, 2024 · 1 comment · Fixed by #2038
Assignees
Labels
auth shouldfix We should do/fix this at some point

Comments

@infomiho
Copy link
Contributor

infomiho commented May 9, 2024

Sometimes users report seeing "An unknown error occurred while trying to log in with the OAuth provider." when things go wrong with the OAuth flow.

This message is sent when something unexpected happens and we don't want to be more specific than this when showing an error on the client:

export function handleOAuthErrorAndGetRedirectUri(error: unknown): URL {

But, this makes it hard to debug for us and for the users. When we redirect with the generic error message, we should also log with console.error on the server.

@infomiho infomiho added shouldfix We should do/fix this at some point auth labels May 9, 2024
@infomiho infomiho self-assigned this May 9, 2024
@ksk385
Copy link

ksk385 commented May 9, 2024

Would this be as simple as passing the unknown error to the callback as a string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth shouldfix We should do/fix this at some point
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants