Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how go-to-definition behaves for Wasp SDK #1986

Open
sodic opened this issue Apr 23, 2024 · 0 comments
Open

Improve how go-to-definition behaves for Wasp SDK #1986

sodic opened this issue Apr 23, 2024 · 0 comments
Labels
dx enhancement New feature or request

Comments

@sodic
Copy link
Contributor

sodic commented Apr 23, 2024

We want the Ctrl+click (go to definition) command to take the user to the symbol's definition inside a source file (TypeScript).

What happens instead:

  • For type definitions, we take them to the .d.ts files in dist.
  • For value definitions, we take them to .js files in dist.
  • When navigating the code inside our SDK, we take them to .js for both types and values. This is especially confusing since the types don't exist in .js files.

What we want to happen:

  • No matter where they are (their code or our SDK), for both types and values, we take them to the .ts file in src.

Check the tanstack packages to see how it's done.

Note

I believe this was working after 0.12.0. It was possibly broken during the fixing effort. However takes on this issue, please check whether this is right so we know what to prevent.

@sodic sodic added enhancement New feature or request dx labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant