Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wart suggestion: MapPartial #649

Open
froth opened this issue May 30, 2022 · 0 comments · May be fixed by #684
Open

Wart suggestion: MapPartial #649

froth opened this issue May 30, 2022 · 0 comments · May be fixed by #684

Comments

@froth
Copy link

froth commented May 30, 2022

I suggest adding a MapPartial Wart similar to OptionPartial and TryPartial. I t should prevent calling the apply method on a Map instance which can throw a java.util.NoSuchElementException.

I tried doing it myself, but I really struggle with the macro syntax. I think that it should be straight forward for someone more experienced in macros.

  test("can't use Map#apply") {
    val result = WartTestTraverser(MapPartial) {
      println(Map(1 -> "")(1))
    }
    assertError(result)("Map#apply is disabled - use Map#getOrElse instead")
  }
@ncreep ncreep linked a pull request Sep 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants