Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths for the compiler plugin break when using with Bloop. #495

Open
ckipp01 opened this issue Dec 3, 2020 · 2 comments
Open

Comments

@ckipp01
Copy link

ckipp01 commented Dec 3, 2020

To be honest, I'm not 100% sure where this request should be, whether it's a question or a bug, but this is in relation to the issue here in Bloop. When using sbt-boop to export the build to the necessary Bloop files, the wart remover plugin is listed as a relative path. I see that this was done in fadeadc to ensure that remote caching works with sbt, but this also broke compilation for Metals users that are using Bloop as a build server with sbt >= 1.4.0, since Bloop is expecting an absolute path here.

I'm not sure what the best solution since I think it may be difficult in Bloop to accurately turn the relative path into an absolute one in all cases. I'm more just creating this to start a conversation to figure out the best way to fix this.

You can find full instructions in the link I provided to the Bloop issue on how to reproduce this, but if there is anything else you need, let me know.

Thanks!

@xuwei-k
Copy link
Collaborator

xuwei-k commented Dec 4, 2020

Thanks for the report. Could you try wartremoverPluginJarsDir := None 🙏

@ckipp01
Copy link
Author

ckipp01 commented Dec 4, 2020

Thanks for the report. Could you try wartremoverPluginJarsDir := None 🙏

Hello! Sorry, I should have included that in the original issue. Yes, that does fix the issue for me, and I was able to verify that when I reported. It was more of a general question to see if there was any way for this to be an absolute path, since this will currently break compilation for any Metals user that is using wart remover with sbt >= 1.4.0 if they are using Bloop as a BSP server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants