Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Provide quick-fixes for each rule #96

Open
roaldnefs opened this issue Nov 10, 2019 · 1 comment
Open

Feature Request: Provide quick-fixes for each rule #96

roaldnefs opened this issue Nov 10, 2019 · 1 comment
Labels

Comments

@roaldnefs
Copy link
Member

As salt-lint is able to detect mistakes it would to nice if it is able to provide a (simple) fix for each of the rules. If a quick-fix is provided by the rule it can be added as optional output in the formatters. When salt-lint is able to suggest quick-fixes it could also provide a command line flag to automatically apply them.

Some editors (e.g. vscode using warpnet/vscode-salt-lint), are able to apply quick fixes to the code with a simple click on the suggestion.

@roaldnefs roaldnefs added Type: Enhancement New feature or request Priority: Low labels Nov 10, 2019
@roaldnefs roaldnefs self-assigned this Nov 10, 2019
@roaldnefs roaldnefs removed their assignment Dec 4, 2020
@kittydoor
Copy link

kittydoor commented Jun 20, 2022

Does anyone have information on what it would take to implement this, i.e. in what way this information is actually supposed to be implemented and communicated to editors and their extensions? From some quick research, Vim doesn't seem to support quickfix actions, and VSCode doesn't really describe where a quickfix action is supposed to come from / if there is a spec for it.

Perhaps I'm missing something obvious?

Edit: I see this seems to be the spec for quickfix actions: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants