Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new displayName property in Fs.File #159

Open
warpdesign opened this issue Jul 9, 2020 · 0 comments
Open

Add a new displayName property in Fs.File #159

warpdesign opened this issue Jul 9, 2020 · 0 comments

Comments

@warpdesign
Copy link
Owner

warpdesign commented Jul 9, 2020

Some FS (eg. WSL) return weird characters that cannot be displayed correctly, for example, a file named file< in Linux would appear as file when displayed in React-Explorer.

The problem is that all forbidden characters in a Windows filename will be visually displayed as , so this directory in Linux:

file<
file>
file*

would be displayed like this in React-Explorer:

file
file
file

Since the filename is displayed in lots of places (eg. the tab title, file table, path bar, etc...), a new displayName property that contains the displayed filename should be added to the FS.File object and every place where the filename property was used to display the filename will have to be replaced by this new prop.

This includes:

  • pathbar
  • filetable (inc. title tooltip)
  • tab title
  • downloads panel
  • error messages ?
@warpdesign warpdesign added this to the Penguin-release (2.4.0) milestone Jul 9, 2020
@warpdesign warpdesign changed the title Add a new dname property in Fs.File Add a new display_name property in Fs.File Jul 9, 2020
@warpdesign warpdesign changed the title Add a new display_name property in Fs.File Add a new displayName property in Fs.File Jul 11, 2020
@warpdesign warpdesign removed this from the Penguin-release (2.4.0) milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant