Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobuild overlays option won't build combined runtime/system overlays #1216

Open
3 tasks done
Prepultrue opened this issue May 8, 2024 · 2 comments
Open
3 tasks done
Labels
bug Something isn't working discuss A topic for discussion in a community meeting
Milestone

Comments

@Prepultrue
Copy link
Contributor

Prepultrue commented May 8, 2024

Steps to reproduce

Remove the existing overlay image so autobuild should rebuild it

rm -f /var/lib/warewulf/provision/overlays/n001/__RUNTIME__.img{,.gz}

Request the runtime overlay image:

# curl -v --local-port 500-1000 'http://WW_HOST:9873/provision/00:11:22:33:44:55?stage=runtime'
*   Trying WW_HOST...
* TCP_NODELAY set
* Local port: 500
* Connected to WW_HOST (WW_HOST) port 9873 (#0)
> GET /provision/00:11:22:33:44:55?stage=runtime HTTP/1.1
> Host: WW_HOST:9873
> User-Agent: curl/7.61.1
> Accept: */*
> 
< HTTP/1.1 404 Not Found
< Date: Wed, 08 May 2024 03:15:47 GMT
< Content-Length: 0
< 
* Connection #0 to host WW_HOST left intact

Error message

[Wed May  8 13:17:27 AEST 2024] RECV   : hwaddr: 00:11:22:33:44:55, ipaddr: WW_HOST:500, stage: runtime
[Wed May  8 13:17:27 AEST 2024] SERV   : stage_file '/var/lib/warewulf/provision/overlays/n001/__RUNTIME__.img'
[Wed May  8 13:17:27 AEST 2024] ERROR  : Not found: /var/lib/warewulf/provision/overlays/n001/__RUNTIME__.img

Information on your system

# wwctl version 
wwctl version:	4.5.1-1
rpc version: apiPrefix:"rc1"  apiVersion:"1"  warewulfVersion:"4.5.1-1"
# cat /etc/os-release 
NAME="Rocky Linux"
VERSION="8.9 (Green Obsidian)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.9"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Rocky Linux 8.9 (Green Obsidian)"
ANSI_COLOR="0;32"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:rocky:rocky:8:GA"
HOME_URL="https://rockylinux.org/"
BUG_REPORT_URL="https://bugs.rockylinux.org/"
SUPPORT_END="2029-05-31"
ROCKY_SUPPORT_PRODUCT="Rocky-Linux-8"
ROCKY_SUPPORT_PRODUCT_VERSION="8.9"
REDHAT_SUPPORT_PRODUCT="Rocky Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.9"
# grep -B3 autobuild /etc/warewulf/warewulf.conf
warewulf:
  port: 9873
  secure: true
  autobuild overlays: true

General information

  • I have run wwctl version and reported the contents of /etc/os-release
  • I have searched the issues of this repo and believe this is not a duplicate
  • I have captured and reported relevant error messages and logs
@Prepultrue Prepultrue added the bug Something isn't working label May 8, 2024
@Prepultrue
Copy link
Contributor Author

This seems to be because:

  • getOverlayFile will only every be called with either context or request_overlays/stage_overlays set
  • overlay.BuildOverlay immediately bails out when no overlayNames are supplied

@griznog
Copy link
Contributor

griznog commented May 8, 2024

More motivation for #1018 ?

@anderbubble anderbubble added this to the v4.5.x milestone May 8, 2024
@anderbubble anderbubble added the discuss A topic for discussion in a community meeting label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discuss A topic for discussion in a community meeting
Projects
None yet
Development

No branches or pull requests

3 participants