Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncuser walks the file system for each user/group #1209

Open
3 tasks done
anderbubble opened this issue Apr 30, 2024 · 0 comments · May be fixed by #1212
Open
3 tasks done

syncuser walks the file system for each user/group #1209

anderbubble opened this issue Apr 30, 2024 · 0 comments · May be fixed by #1212
Assignees
@anderbubble
Labels
bug Something isn't working
Milestone
v4.5.3

Comments

@anderbubble
Copy link
Collaborator

Steps to reproduce

wwctl container syncuser walks the full fs for every user. It should just walk the fs once and catalog files that need to be updated in one linear search.

Error message

No error message. Just bad behavior.

Information on your system

Curent on Warewulf main. Made more visible using #1207.

General information

  • I have run wwctl version and reported the contents of /etc/os-release
  • I have searched the issues of this repo and believe this is not a duplicate
  • I have captured and reported relevant error messages and logs
@anderbubble anderbubble added the bug Something isn't working label Apr 30, 2024
@anderbubble anderbubble self-assigned this Apr 30, 2024
@anderbubble anderbubble modified the milestones: v4.5.x, v4.5.2 Apr 30, 2024
anderbubble added a commit to anderbubble/warewulf that referenced this issue May 2, 2024
@anderbubble
Refactor syncuser to only walk the container fs once
3b63a5d 
- Closes warewulf#1209

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
@anderbubble anderbubble linked a pull request May 2, 2024 that will close this issue
Open
6 tasks
anderbubble added a commit to anderbubble/warewulf that referenced this issue May 2, 2024
@anderbubble
Refactor syncuser to only walk the container fs once
b901c0a 
- Closes warewulf#1209

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
anderbubble added a commit to anderbubble/warewulf that referenced this issue May 2, 2024
@anderbubble
Refactor syncuser to only walk the container fs once
32d67eb 
- Closes warewulf#1209

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
anderbubble added a commit to anderbubble/warewulf that referenced this issue May 2, 2024
@anderbubble
Refactor syncuser to reduce walking the container fs
473c92a 
- Closes warewulf#1209

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
anderbubble added a commit to anderbubble/warewulf that referenced this issue May 6, 2024
@anderbubble
Refactor syncuser to reduce walking the container fs
8997c74 
- Closes warewulf#1209

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
@anderbubble anderbubble modified the milestones: v4.5.2, v4.5.3 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anderbubble anderbubble

Labels
bug Something isn't working
Projects
None yet
Milestone
v4.5.3
Development

Successfully merging a pull request may close this issue.

Refactor syncuser to reduce walks of the container fs anderbubble/warewulf
1 participant
@anderbubble