Fix overlay directory location/creation #1182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderbubble
added
backported:4.5.x
anderbubble
changed the title
anderbubble
force-pushed
the
CleanupAfterShell
branch
from
9270b47
to
e99c37d
Compare
|
Rebased on main and updated changelog. |
anderbubble
force-pushed
the
CleanupAfterShell
branch
2 times, most recently
from
8d4517b
to
e3c0ac9
Compare
anderbubble
requested changes
Apr 20, 2024
anderbubble
force-pushed
the
CleanupAfterShell
branch
from
e3c0ac9
to
2b6cbc5
Compare
Signed-off-by: Christian Goll <cgoll@suse.com>
mslacken
force-pushed
the
CleanupAfterShell
branch
from
2b6cbc5
to
d2d46f0
Compare
The directories for the overlays needed for the bind mount are now created under conf.Paths.WWChrootdir/$CONTAINERNAME with the pattern $CONTAINERNAME-run-xxxxxx. This pattern can be used as lock, so that there can't be congruent shell/exec calls to the same container. Signed-off-by: Christian Goll <cgoll@suse.com>
mslacken
force-pushed
the
CleanupAfterShell
branch
from
d2d46f0
to
ef518c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/lib/warewulf/chroots/overlaydirectory should be somewhere else. #1180The directories for the overlays needed for the bind
mount are now created under
conf.Paths.WWChrootdir/$CONTAINERNAMEwith the pattern
$CONTAINERNAME-run-xxxxxx. This pattern can beused as lock, so that there can't be congruent shell/exec calls
to the same container.