add CIDR format to warewulf.conf parse #1150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderbubble
requested changes
Mar 28, 2024
internal/pkg/config/root.go
Outdated
Comment on lines
105
to
108
| conf.Ipaddr = ip.String() | ||
| conf.Network = network.IP.String() | ||
| mask := network.Mask | ||
| conf.Netmask = fmt.Sprintf("%d.%d.%d.%d", mask[0], mask[1], mask[2], mask[3]) |
There was a problem hiding this comment.
conf.Network and conf.Netmask should only be populated here if they don't have their own value specified in the config file.
JasonYangShadow
force-pushed
the
issue/1130
branch
from
5ddf545
to
806ef6f
Compare
Signed-off-by: Xu Yang <xyang@ciq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
when parsing warewulf.conf, CIDR format will cause issue.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
git commit --signoff) in agreement to the DCO