Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container don't get built at import #1128

Open
mslacken opened this issue Mar 11, 2024 · 3 comments
Open

container don't get built at import #1128

mslacken opened this issue Mar 11, 2024 · 3 comments
Labels
bug Something isn't working discuss A topic for discussion in a community meeting regression stake:suse Suse is a stakeholder of this issue
Milestone
v4.6.0

Comments

@mslacken
Copy link
Member

mslacken commented Mar 11, 2024 •
edited

Containers don't get build if the SyncUid command fails. In 4.4.0 the container image still gets build. We should restore the old behavior.
@mslacken mslacken added the bug Something isn't working label Mar 11, 2024
@mslacken mslacken added this to the v4.5.1 milestone Mar 11, 2024
@anderbubble anderbubble added regression discuss A topic for discussion in a community meeting labels Mar 11, 2024
@anderbubble anderbubble changed the title container don't get build at import container don't get built at import Mar 11, 2024
@anderbubble
Copy link
Collaborator

@mslacken does it build if you specify wwctl container import --build?

@mslacken
Copy link
Member Author

mslacken commented Mar 11, 2024 •
edited

Did not check for parameters, yet.
Btw. why did have the --build if in 4.4.0 the image was always build?

@anderbubble
Copy link
Collaborator

@mslacken I don't know why the --build option was there before; it doesn't appear that it did anything.

Previously the behavior was to build if syncuser didn't have any complaints but to not build if it did.

Now the current behavior is to never build automatically, but to build if --build is specified.

Do we need to change this behavior? Personally, I think the new behavior is less surprising; but it wasn't necessarily intentional.

@anderbubble anderbubble added the stake:suse Suse is a stakeholder of this issue label Mar 20, 2024
@anderbubble anderbubble modified the milestones: v4.5.1, v4.6.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working discuss A topic for discussion in a community meeting regression stake:suse Suse is a stakeholder of this issue
Projects
None yet
Milestone
v4.6.0
Development

No branches or pull requests
2 participants
@anderbubble @mslacken