[discussion] [question] [feature request] Support assertion data diff view for sinon-chai

[hellboy81]

Is there possible to compare visually parameters in sinon-chai assertions:

.. .should.have.been.calledWith(....)

Is there possible in release 1.0.24 display chai.js assertion errors (demo from twitter)?

[ArtemGovorov]

We are using chai convention where AssertionError is raised with showDiff flag for those assertions that it makes sense to show the diff for. So it's up to the assertion library to set the flag and if I'm not mistaken, sinon-chai doesn't set the flag for its assertions.

I'll se what we can do about it.

[boneskull]

I'm going to be taking a look at Wallaby, but sinon-chai and chai-as-expected support is going to be crucial for me.

[ArtemGovorov]

@boneskull wallaby supports both sinon-chai and chai-as-expected (any assertion framework really), this issue is about this feature support for sinon-chai assertion errors

[hellboy81]

Discussion updated

[ArtemGovorov]

@hellboy81 Thanks, so as soon Sinon-chai is fixed to pass expected, actual and showDiff for certain assertions, wallaby.js 'Show Diff' feature will just work.