Allow icons with unquoted/single-quoted ids in the styleguide #11903
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
commented
Apr 29, 2024
| @@ -30,7 +30,7 @@ Draw or download an icon and save it in a template folder: | |||
|
|
|||
| The `svg` tag should: | |||
|
|
|||
| - Set the `id="icon-<name>"` attribute, icons are referenced by this name. | |||
| - Set the `id="icon-<name>"` attribute, icons are referenced by this `name`. The `name` should only contain lowercase letters, numbers, and hyphens. | |||
There was a problem hiding this comment.
Pretty sure this limitation only exists because of the styleguide's regex, and the icons can technically still be used elsewhere as long as the ID is prefixed with icon-. Alternatively we could update the regex to be more permissive.
Manage this branch in SquashTest this branch here: https://laymonagefix-styleguide-icon-q-6wvk1.squash.io |
|
Bumping to 6.2, since at this point any new additions to 6.1 should only really be regressions and critical issues (to minimise the possibility of introducing new issues that haven't been tested with a release candidate). |
laymonage
force-pushed
the
fix-styleguide-icon-quotes
branch
from
7ee597f
to
452fe54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11895. The HTML spec allows attributes to have no value, unquoted value, single-quoted value, and double-quoted value: https://html.spec.whatwg.org/multipage/syntax.html#attributes-2
This issue has been around since the styleguide's icon list was reimplemented as a table in 43ca8be. In the implementation, our regex only considers the most common use case (double-quoted value).