Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for preparing icon listings for documentation no longer work #11771

Open
lb- opened this issue Mar 17, 2024 · 1 comment
Open

Instructions for preparing icon listings for documentation no longer work #11771

lb- opened this issue Mar 17, 2024 · 1 comment

Comments

@lb-
Copy link
Member

lb- commented Mar 17, 2024

Pertinent section of the Wagtail docs

<!-- In DevTools: copy($$('[data-icons-table^="wagtailadmin"]')[0].innerHTML.replace(/\s+/g, ' ').replace(/<t/g, '\n<t')) -->

When I ran that I did not get the actual SVG content, only the svg use references.

The actual svg sources (paths etc) are needed for the generated content https://github.com/wagtail/wagtail/blob/main/docs/_static/wagtail_icons_table.txt

Which gets used on this page: https://docs.wagtail.org/en/stable/advanced_topics/icons.html

Details

The output generated does not contain the actual SVG but just the reference.

<tr> 
<td><svg class="icon icon-folder-inverse w-w-8 w-h-8" aria-hidden="true"><use href="#icon-folder-inverse"></use></svg></td> 
<td><code>folder-inverse</code></td> 
<td> folder (solid): Font Awesome Pro 6.4.0 </td> 
<td><code>wagtailadmin/icons/folder-inverse.svg</code></td> </tr> 
<tr> 

Originally posted by @rohitsrma in #11768 (comment)

Not sure when this broke but it appears that the last sets of new icons were added over a year ago so maybe sometime since then. See #10320

It's possible this has never worked since we updated to use the new sprite approach sometime around 2022.

Working on this

  • It's recommended that someone with knowledge of this original set up help support this issue.
  • There may be a better way to do this instead of copy/pasting console output.
@lb-
Copy link
Member Author

lb- commented Mar 17, 2024

@thibaudcolas or @laymonage - do either of you know when the icon copy script last worked? Or if we are doing something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant