Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on JavaScript code snippets with long line #724

Open
heybran opened this issue Jul 15, 2023 · 0 comments
Open

Feedback on JavaScript code snippets with long line #724

heybran opened this issue Jul 15, 2023 · 0 comments

Comments

@heybran
Copy link

heybran commented Jul 15, 2023

Hi,

Greeting from China. As an user who spends quite a lot time reading articles on my phone, for this page: https://www.w3.org/WAI/tutorials/forms/notifications/, on section Example 1: Binary messages, when we have JavaScript code that has longer length (please see below screenshot taken on my iPhone 11, Safari IOS 16.5.1), it makes the layout of the whole page a bit broken.

I would suggest:

  1. Add a overflow-x: auto to <div class="language-js highlighter-rouge">, this will improve the reading experience for some users, but not sure if the same for all users.
    or
  2. Refactor the JavaScript codes to make it shorter to fit well with smaller screen, but I don't think this will fix the problem as their are phones with smaller sizes. (I can work on this part if we're going with this one).

Anything I've missed? Or is there any better solution? Thanks

WechatIMG41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant