You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that in the Carousel tutorial, depending on the active slide, accessible names for the matching buttons get updated on the fly (from "News n" to "News n (Current Item)".
In #650 I tried to remediate this by using aria-pressed (for the Play/Pause button) and aria-current for the navigation buttons. Unfortunately I'm not able to run Jekyll on my ARM-based Mac, so I have to rely on Netlify's deploy previews.
Regarding that: why does the JavaScript code in carousel.js and working-example.md differ?
/Edit: Not talking about missing comments but to be more precise – startAnimation() and stopAnimation() function definitions are different
The text was updated successfully, but these errors were encountered:
If we change that approach, we also need to explain that in the tutorial text, I think. People are still quite inexperienced with various ARIA things.
Regarding that: why does the JavaScript code in carousel.js and working-example.md differ?
/Edit: Not talking about missing comments but to be more precise – startAnimation() and stopAnimation() function definitions are different
Hi,
I noticed that in the Carousel tutorial, depending on the active slide, accessible names for the matching buttons get updated on the fly (from "News n" to "News n (Current Item)".
In #650 I tried to remediate this by using
aria-pressed
(for the Play/Pause button) andaria-current
for the navigation buttons. Unfortunately I'm not able to run Jekyll on my ARM-based Mac, so I have to rely on Netlify's deploy previews.Regarding that: why does the JavaScript code in carousel.js and working-example.md differ?
/Edit: Not talking about missing comments but to be more precise –
startAnimation()
andstopAnimation()
function definitions are differentThe text was updated successfully, but these errors were encountered: