Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing accessible names dynamically for carousel buttons #651

Open
marcus-herrmann opened this issue Mar 12, 2022 · 2 comments
Open

Comments

@marcus-herrmann
Copy link

marcus-herrmann commented Mar 12, 2022

Hi,

I noticed that in the Carousel tutorial, depending on the active slide, accessible names for the matching buttons get updated on the fly (from "News n" to "News n (Current Item)".

In #650 I tried to remediate this by using aria-pressed (for the Play/Pause button) and aria-current for the navigation buttons. Unfortunately I'm not able to run Jekyll on my ARM-based Mac, so I have to rely on Netlify's deploy previews.

Regarding that: why does the JavaScript code in carousel.js and working-example.md differ?
/Edit: Not talking about missing comments but to be more precise – startAnimation() and stopAnimation() function definitions are different

@yatil
Copy link
Contributor

yatil commented Mar 17, 2022

If we change that approach, we also need to explain that in the tutorial text, I think. People are still quite inexperienced with various ARIA things.

Regarding that: why does the JavaScript code in carousel.js and working-example.md differ?
/Edit: Not talking about missing comments but to be more precise – startAnimation() and stopAnimation() function definitions are different

Maybe a copy & paste error…

@marcus-herrmann
Copy link
Author

Updated #650,…

  • transported the changes regarding aria-current from carousel.js to working-example.md
  • added a sh*tty first draft regarding the necessary text change
  • but ⚠️ wasn't able to change the included rendered example in box.html because I'm not able to find it in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants