Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the domain of closed to be applicable to more than just Question? #594

Open
trwnh opened this issue Apr 28, 2024 · 5 comments
Open
Labels
Next version Things that should probably be resolved in a next version of AS2

Comments

@trwnh
Copy link

trwnh commented Apr 28, 2024

as:closed seems like it'd be useful on more than just Question types. say you had a comments section (represented by a Collection probably) and you wanted to declare it to be closed. is this semantically different enough to justify a completely different property? it also seems like it wouldn't work with the extension policy, since it would conflict with the existing definition for closed as as:closed.

tangentially, it seems like the intended usage of as:closed is kind of like marking a question as "solved". so maybe that deserves further thought.

@steve-bate
Copy link

The Question concept in AS2 seems to have never been fully thought through. See this, for example. However, I don't have the impression that as:closed for as:Question was intended to mean solved but that no further interaction is allowed (e.g., a poll that has been completed and no longer accepting responses).

Any AS2 Object can include predicates from any vocabulary. For example, they might include terms from schema.org. I don't see why they could not also include "extension" terms (relative to the base normative definition for that Object) from the AS2 vocabulary. In other words, they could use as:closed with as:Collection even if it's not defined as the domain for the as:closed predicate in the AS2 Recommendation.

@trwnh
Copy link
Author

trwnh commented Apr 29, 2024

The Question concept in AS2 seems to have never been fully thought through. See #297 (comment), for example.

fair point, it also seems to indicate that closed was never thought through either. we have another issue in #542 regarding the range of the property (and of similar issues with the url property as defined in the context document). but closed being a boolean or a datetime or a graph node (Object/Link) seems like it's doing a lot of things. particularly the last case is what prompted my comment ("this Question is closed by (or closedBy?) the following object/link)

if the meaning truly were "no further interaction is allowed", then that would be imo an argument for making it more generic and loosening the domain restriction.

@steve-bate
Copy link

it also seems to indicate that closed was never thought through either

I agree with all those points.

@evanp
Copy link
Collaborator

evanp commented May 1, 2024

This seems like a backwards-compatible change. It's not an error that requires an Errata, but I think it would require a text change.

So: roughly, if it is useful for other types, that needs some documentation. We can expand the domain to Object in a future version of the Vocabulary.

@evanp evanp added the Next version Things that should probably be resolved in a next version of AS2 label May 1, 2024
@evanp
Copy link
Collaborator

evanp commented May 1, 2024

You can think of this as the decriminalization of using closed on other types, and then at some point we can legalize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next version Things that should probably be resolved in a next version of AS2
Projects
None yet
Development

No branches or pull requests

3 participants