Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a minor mistake in the Remove example? #534

Open
sfolsom opened this issue Apr 4, 2023 · 3 comments
Open

Is there a minor mistake in the Remove example? #534

sfolsom opened this issue Apr 4, 2023 · 3 comments
Assignees

Comments

@sfolsom
Copy link

sfolsom commented Apr 4, 2023

Should this (

) be using the as:origin property rather than as:target?

See:

<code>object</code>. If specified, the <code>origin</code>
.

@csarven
Copy link
Member

csarven commented Apr 4, 2023

It seems to be that origin ("from") would be more fitting than target ("to") for the Remove activity, and that example.

Remove object from location.

Add object from location to location.
Remove object from location.
Delete object from location.
Move object from location to location.
...

@pietercolpaert
Copy link

I came here to open exactly this issue. The description text is correct, but the Remove example was probably wrongly copy pasted from the Add example.

@evanp
Copy link
Collaborator

evanp commented Jul 6, 2023

So, it seems like an error in the example code. The correct resolution is to add an erratum that says "target" should be "origin" in this example.

Unfortunately, ActivityPub defines the Remove activity to use "target". So, we will probably need to recommend that implementers support "origin" by default, and "target" as a fallback, regardless of the unfortunate illogic of it.

@evanp evanp self-assigned this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants