Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Support nvim-notify #131

Open
1 task done
ecosse3 opened this issue Sep 11, 2022 · 4 comments · May be fixed by #143
Open
1 task done

[FEATURE REQUEST] Support nvim-notify #131

ecosse3 opened this issue Sep 11, 2022 · 4 comments · May be fixed by #143
Labels
🙏 Feature Request Feature requests not planned anywhere

Comments

@ecosse3
Copy link

ecosse3 commented Sep 11, 2022 •
edited

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

Hi,

it would be nice if this plugin could support nvim-notify via a specific option. It could look like that:

image

Even displaying current npm installation progress (if possible):

152641078-92f3da72-f49f-4705-aec8-86512693445f

I think it's a great addition to this plugin.

Regards

Help

Yes, but I don't know how to start. I would need guidance

Implementation help

I need time to understand how your queue works and if I need it with nvim-notify. Probably not since nvim-notify supports it somehow by default by displaying multiple notifications at once with a timeout. Will take a look in next week to implement this feature but I cannot guarantee the best code quality or tests (I've never tested with lua).
@ecosse3 ecosse3 added the 🙏 Feature Request Feature requests not planned anywhere label Sep 11, 2022
@vuki656
Copy link
Owner

vuki656 commented Sep 12, 2022

Hey, that's a good idea since it works out of the box for everyone instead of relying on status bar customizability.

Give it a go and let me know if you have any questions.

I'd be happy to help along the way.

@luisfrocha
Copy link

Any updates on this? I'd be interested in it. I'm currently trying to get the status to show up in Lualine but haven't been able to.

@vuki656
Copy link
Owner

vuki656 commented Jul 25, 2023

Any updates on this? I'd be interested in it. I'm currently trying to get the status to show up in Lualine but haven't been able to.

Hey @luisfrocha, could you paste your lualine code which didn't work?

As for the ticket itself, im open to review a PR.

@agoodshort agoodshort linked a pull request Oct 5, 2023 that will close this issue
Open
@vuki656
Copy link
Owner

vuki656 commented Oct 6, 2023

Hey, could you check #143 and provide feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙏 Feature Request Feature requests not planned anywhere
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add nvim-notify support agoodshort/package-info.nvim
3 participants
@luisfrocha @vuki656 @ecosse3